Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Fix headless and service proxy name tc's #29

Merged
merged 1 commit into from
May 28, 2021
Merged

Fix headless and service proxy name tc's #29

merged 1 commit into from
May 28, 2021

Conversation

VivekThrivikraman-est
Copy link
Contributor

This PR is for fixing the below failing test cases :

  • [Fail] [sig-network] Services [It] should implement service.kubernetes.io/service-proxy-name
  • [Fail] [sig-network] Services [It] should implement service.kubernetes.io/headless

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 28, 2021
@k8s-ci-robot k8s-ci-robot requested review from mcluseau and thockin May 28, 2021 15:21
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: VivekThrivikraman-est
To complete the pull request process, please assign thockin after the PR has been reviewed.
You can assign the PR to them by writing /assign @thockin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @VivekThrivikraman-est!

It looks like this is your first PR to kubernetes-sigs/kpng 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kpng has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 28, 2021
@mcluseau mcluseau merged commit 4a67a64 into kubernetes-retired:master May 28, 2021
VivekThrivikraman-est added a commit to jayunit100/kpng that referenced this pull request Jul 11, 2021
@VivekThrivikraman-est
Fix headless and service proxy name tc's (kubernetes-retired#29)
2a6fb0d
jayunit100 pushed a commit to jayunit100/kpng that referenced this pull request Oct 1, 2021
@VivekThrivikraman-est @jayunit100
Fix headless and service proxy name tc's (kubernetes-retired#29)
af9faba
@VivekThrivikraman-est VivekThrivikraman-est mentioned this pull request Dec 7, 2021
Closed
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcluseau mcluseau Awaiting requested review from mcluseau

@thockin thockin Awaiting requested review from thockin

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VivekThrivikraman-est @k8s-ci-robot @mcluseau